HVX F32-raddstoreexpminusmax microkernels for Softmax
#6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ejparkqc
commented
Jun 30, 2024
ejparkqc
commented
- Initial implementation and test added.
- xnnpack/intrinsics-polyfill.h has the horizontal sum code (Q6_f32_vrsum_Vsf) using vshuff and vadd.
ejparkqc
force-pushed
the
f32-raddstoreexpminusmax
branch
from
ac94723
to
2d4f5c8
Compare
fbarchard
reviewed
Jun 30, 2024
| // This source code is licensed under the BSD-style license found in the | ||
| // LICENSE file in the root directory of this source tree. | ||
|
|
||
| $assert BATCH_TILE % 4 == 0 |
There was a problem hiding this comment.
multiple of 32 floats.
$assert BATCH_TILE % 32 == 0
There was a problem hiding this comment.
Thank you Frank, fixed it. Also, I will revisit other previous kernels if I put 4 instead of 32.
ejparkqc
force-pushed
the
f32-raddstoreexpminusmax
branch
12 times, most recently
from
243cf7a
to
fb2bf91
Compare
ejparkqc
changed the title
F32-raddstoreexpminusmax microkernels for Softmax
ejparkqc
force-pushed
the
f32-raddstoreexpminusmax
branch
4 times, most recently
from
2fd85ea
to
92ee2dd
Compare
fbarchard
reviewed
Jul 9, 2024
src/xnnpack/intrinsics-polyfill.h
Outdated
| float* svin2 = (float *) &vin2; | ||
|
|
||
| for(int i = 0; i < 32; i++) | ||
| svin1[i] = svin1[i] / svin2[i]; |
There was a problem hiding this comment.
suggest adding a todo to improve on this. if div is not an option, perhaps try to make calling code use 'nr' - reciprocal.
There was a problem hiding this comment.
Quick question - does XNNPACK has nr code already implemented or should we add? I added as a TODO for now, but definitely want to improve this.
fbarchard
approved these changes
Jul 9, 2024
ejparkqc
force-pushed
the
f32-raddstoreexpminusmax
branch
from
92ee2dd
to
458ec60
Compare
ejparkqc
force-pushed
the
f32-raddstoreexpminusmax
branch
from
458ec60
to
73e810f
Compare
|
Thanks, importing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.