Make the integration and hammer tests use a verifier per log #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case someone should make them stateful at some point really soon now. Fix a few warnings while in there.
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 88 88
Lines 9446 9446
=======================================
Hits 6809 6809
Misses 2151 2151
Partials 486 486Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 72.08% 72.08%
=======================================
Files 88 88
Lines 9446 9446
=======================================
Hits 6809 6809
Misses 2151 2151
Partials 486 486Continue to review full report at Codecov.
|
daviddrysdale
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports hashers that are not thread safe if we change how the
merkle.LogVerifierworks in future, which is reasonably likely.And fix up a couple of warnings while I'm in there.