Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a possible but unlikely crash in sctscan util #592

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

Martin2112
Copy link
Contributor

Can currently try to log something not guarded by a nil check.

Checklist

@Martin2112 Martin2112 removed the request for review from daviddrysdale July 31, 2019 10:58
@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #592 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
- Coverage   71.82%   71.68%   -0.14%     
==========================================
  Files          90       90              
  Lines        9791     9737      -54     
==========================================
- Hits         7032     6980      -52     
  Misses       2265     2265              
+ Partials      494      492       -2
Impacted Files Coverage Δ
ctpolicy/ctpolicy.go 34.37% <0%> (-7.3%) ⬇️
ctpolicy/applepolicy.go 77.77% <0%> (-4.58%) ⬇️
submission/races.go 81.67% <0%> (-3.06%) ⬇️
scanner/scanner.go 55.41% <0%> (-1.28%) ⬇️
submission/distributor.go 83.55% <0%> (+0.1%) ⬆️
ctpolicy/chromepolicy.go 79.31% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261a066...b11ad5f. Read the comment docs.

@Martin2112 Martin2112 merged commit 2f50c21 into google:master Aug 1, 2019
@Martin2112 Martin2112 deleted the sctscan_nil_ptr branch August 1, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants