Fix possible (unlikely) nil pointer access in instance_test #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptypes.TimestampString() is nil safe but before that we convert it to a timestamp proto via a pointer that could be nil. Fix possible but unlikely crash in instance_test Would need to have bad test data to trigger it so not a major issue.
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 71.74% 71.74%
=======================================
Files 90 90
Lines 9737 9737
=======================================
Hits 6986 6986
Misses 2261 2261
Partials 490 490Continue to review full report at Codecov.
|
AlCutter
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptypes.TimestampString()is nil safe but before that we convert it to a timestamp proto via a pointer that could be nil.Would need to have bad test data to trigger it so not a major issue.
Checklist