-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES6] URISyntaxException if absolute path to input has a space #1219
Comments
v20151015 crashes with the --language_in=ECMASCRIPT6 option when the input file paths contain a space (as is apparently the case on the Selenium CI) This has been reported in google/closure-compiler#1219 This reverts commit 2c04320.
Hey Martin, do you have time to take a look at this? Are module names allowed to have spaces? If so, how are spaces escaped in the module name? I looked at ES6ModuleLoader.java and backward slashes are replaced. The javadoc of the class mentions section 26.3.3.18.2 of the spec, but I couldn't find such a section here: |
If you can give me some pointers about what's the desired behavior, I can do the fix. |
For the URI, could you just encode the space ( In toModuleName(URI), you could convert the |
Sorry, I've been traveling, only saw this now. The solutions LGTMs. |
Np, the resolution turned out to be simple. |
This can be reproduced with empty files, you just need to use a directory that contains a space somewhere in the path.
The text was updated successfully, but these errors were encountered: