#3840 - allow user to pass any path separator as --chunk_output_path_prefix

[DerGernTod]

i recreated this PR since somehow the CLA bot didn't recognize me

fixes #3840 - allow user to pass any path separator as --chunk_output_path_prefix

as a user, you might want to use unix-style path separators always, since they're also compatible with windows. doing so however causes issues when writing source maps, since maybeCreateDirsForPath only creates output directories if path separators are in os-style.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[rahul-kamat]

Looks like the CLA bot still doesn't recognize you. Did you follow the steps in https://github.com/google/closure-compiler/pull/3988/checks?check_run_id=7995613406

[aepfli]

hi, as i am part of the POC within dynatrace regarding Open Source contribution, I thought it is worth to add what we did so far, maybe we (Point of contacts) screwed up or missed a step :):

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to [go/cla#troubleshoot](http://go/cla#troubleshoot) ([Public version](https://opensource.google/docs/cla/#troubleshoot)).
  -> We did that and added him within our google workspace group for google contributors

• The email used to register you as an authorized contributor must be the same email used in your Git commits. Check [your existing CLA data](https://cla.developers.google.com/clas) and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).
  -> verified via API emails are equal -

  curl --location --request GET 'https://api.github.com/repos/google/closure-compiler/pulls/3988/commits' \
  --header 'Authorization: token <insert PAT>' \
  --header 'Accept: application/vnd.github.v3+json'
  

• The email used to register you as an authorized contributor must also be [attached to your GitHub account](https://github.com/settings/emails).
  -> visible on the profile and also visible via GitHubs User API

  curl --location --request GET 'https://api.github.com/users/dergerntod' \
  --header 'Authorization: token <insert PAT>'' \
  --header 'Accept: application/vnd.github.v3+json'
  

• You may have [Keep my email address private](https://github.com/settings/emails#:~:text=Keep%20my%20email%20addresses%20private) enabled. Without a visible email address, the CLA cannot be checked. Uncheck it and re-create the offending commit, or have your CLA point of contact add your @users.noreply.github.com address to the CLA group.
  -> visible as seen on profile and GitHubs User API

  curl --location --request GET 'https://api.github.com/users/dergerntod' \
  --header 'Authorization: token <insert PAT>'' \
  --header 'Accept: application/vnd.github.v3+json'
  

We're not sure what we might have missed and we highly appreciate guidance regarding this, so we can move forward 🙂

[frigus02]

Hi. Sorry for long wait. We've never had to troubleshoot a CLA issue in a while, so weren't sure how. I just followed our internal docs.

• Our system can't find a signed CLA for gernot.raudner@dynatrace.com (last checked 10mins ago)
• We have an accepted corporate CLA for Dynatrace LLC

@aepfli , can I ask you to check one more time if:

• The email is in your Google Group containing authorized contributors
• The email matches character for character and lower/uppercase

If everything looks correct on your side, then I will need to file an issue internally. Maybe the CLA bot tripped up on something.

[aepfli]

hi, sorry for the long wait on my side I checked, and @DerGernTod and his email gernot.raudner@dynatrace.com is part of our google-contributors group as you can see on the screenshot.

should we check something else @frigus02? i am not sure if we might miss something here

[frigus02]

Thanks for confirming, @aepfli. I filed an issue internally with the CLA team. I'm going to keep you updated here.

[frigus02]

@aepfli, can you share the full name (i.e. email address) of the "google-contributors" group shown in the screenshot? It is possible that the group of authorized contributors should be something like <company-name>@googlegroups.com. I'm not sure if this is sensitive information. Feel free to send via email to jankuehle@google.com.

[aepfli]

you mean this kind of information?

[frigus02]

@aepfli, yes that's what I was talking about. A colleague informed me that this is not the Google Group associated with your CLA. The currently associated group is dynatrace-llc-contribution@googlegroups.com. If you don't have access to that group or want to change it, I recommend you send an email to cla-submissions@google.com. According to https://cla.developers.google.com/about, they should be able to help.

[aepfli]

Thank you @frigus02 for the help, I am now investigating who might have access to this google group, and I also try to set it to the workspace group :) THANK YOU, very much!

[frigus02]

No worries. Feel free to ping me here if you're stuck.

[DerGernTod]

CLA should work now, i changed the commit message in the previous commit to retrigger the CLA bot

[frigus02]

Good to hear you got the CLA working. Re-assigned to Bradford, as he already reviewed previous attempt. He's also more familiar with the code than I am.

[brad4d]

This looks good.
I'm importing it and sending it through internal review and submission.