InlineSimpleMethods @noinline and PropertyRenameFunction #4072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3967 made it so methods that are used in reflection were not devirtualized, but that didn't prevent them from being inlined by InlineSimpleMethods. This could lead to broken code if a decorator (using
goog.reflect.objectProperty
) tried to modify a method that was being inlined. It would still modify the method, but all uses of the method would be replaced by the original source inline body, sans the decorator's modifications.