-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reading Time support #122
Comments
Oh this is a nice idea! I've seen it on other Hugo sites but didn't realize it was a built-in page variable until you pointed it out. You can also see an example of a conditional element based on a param in that page to show the feedback buttons below the content. Once you've updated the file you'd also need to define a condition and put it in the example site's config.toml, plus some styling to display the reading time. Here's an example from a non-Docsy Hugo site that uses a reading time (though they don't have a param to switch it on and off AFAIK): https://github.com/istio/istio.io/blob/master/layouts/partials/primary_top.html If you'd like to have a go I'm happy to review it/answer questions;. |
@LisaFC great thanks I'll try to give it a go in the next few weeks. |
Hurrah! Let me know if you need any help. Assign yourself here for now so we know you're working on it. |
Can you assign me, I don't seem to be able to assign myself? |
… On Wed, Aug 21, 2019 at 11:20 AM Alex Earnshaw ***@***.***> wrote:
Can you assign me, I don't seem to be able to assign myself?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#122?email_source=notifications&email_token=ACESRV5TFRRRFQWWOJKGEIDQFVMMLA5CNFSM4IOGFZ3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD42A64A#issuecomment-523505520>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACESRV55NCBH6QIUS2UHCYDQFVMMLANCNFSM4IOGFZ3A>
.
|
Hi there, I've just implemented this feature for docsy-theme for my custom theme 😎 The code is next:
Finally, the result appears and.... tadaaaa 🎉 !!! Here it's a screenshot: I dont know how to configure this to achieve this for @alexearnshaw Have a config param that allows users to turn displaying the reading time on or off (link) BTW, I hope I could have helped and resolved the issue!!! 😃 Regards. |
@frodriguezsmartclip Thanks this is helpful. @LisaFC Sorry about leaving this so long, other priorities etc, but I think I can confidently give this a go now...will update as soon as I have something working! |
Hi everyone who was interested in this, this is now merged but should we have it enabled or disabled by default? I'm thinking "not enabled" but would like to know what you think. |
@LisaFC I think, in my opinion, enabled by default because it's a nice feature to show it up... |
This is a feature request.
I'd like to be able to optionally display the estimated reading time for a documentation page or blog post.
It seems like Hugo has a page variable for Reading Time so I think this could be implemented fairly easily as discussed here https://discourse.gohugo.io/t/readingtime-define/13036/3
Would be happy to have a go at a PR for this if someone could get me started in the right direction...I'm fairly new to hugo and docsy!
The text was updated successfully, but these errors were encountered: