Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a offline search issue that escaped HTML entities is shown #275

Merged
merged 5 commits into from
Jun 15, 2020

Conversation

tekezo
Copy link
Contributor

@tekezo tekezo commented May 23, 2020

This PR fixes a offline search issue that escaped HTML entities is shown as follows, and adds two configuration options.

Fix an issue

Before:
Screen Shot 2020-05-23 at 14 14 37

After:
Screen Shot 2020-05-23 at 14 17 34

Add configuration options

  • offlineSearchSummaryLength which changes the summary length.
  • offlineSearchMaxResults which changes the maximum result count.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this feature, does it would it paginate if the results are more than the screen? if not it still a great PR ! thank you

@tekezo
Copy link
Contributor Author

tekezo commented May 24, 2020

@medyagh I'm not planned to add pagination because lunr.js always returns entire results.
So, the pagination will reduce only the rendering cost.

@medyagh
Copy link
Member

medyagh commented Jun 12, 2020

@medyagh I'm not planned to add pagination because lunr.js always returns entire results.
So, the pagination will reduce only the rendering cost.

sounds good, I look forward for this PR to be merged ! I would like to use this feature

@LisaFC LisaFC merged commit b005fbb into google:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants