Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4590 Fix Conan build #5449

Merged
merged 2 commits into from
Jul 25, 2019
Merged

#4590 Fix Conan build #5449

merged 2 commits into from
Jul 25, 2019

Conversation

uilianries
Copy link
Contributor

@uilianries uilianries commented Jul 23, 2019

  • Create separated build for Conan on master branch
  • Add Clang 7,8
  • Add Gcc 9

Travis uses an Ubuntu images which by default is running python 2. The idea here is moving the Conan job to a separated context, using Docker + Python 3, but without any upload, as the current situation.

Related discussion: #4590 (comment)

/cc @aardappel

- Create separated build for Conan on master branch
- Add Clang 7,8
- Add Gcc 9

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Contributor Author

This is interesting, there are some errors, but they are not related to my changes.

@aardappel
Copy link
Collaborator

Yes, looks like the generated code is not up to date. I'll see if I can fix that after I merge this. Thanks for the fix!

@aardappel aardappel merged commit a0c0131 into google:master Jul 25, 2019
@uilianries
Copy link
Contributor Author

You are welcome!

@aardappel
Copy link
Collaborator

@uilianries This Conan related error just popped up in CI, any idea? https://travis-ci.org/google/flatbuffers/jobs/591651086

@uilianries
Copy link
Contributor Author

Hi @aardappel !

Conan Package Tools is helper for CI jobs, but it requires Conan installed. Conan 1.19.0 has been released today, also we release a new version for CPT (conan package tools). Probably, the CPT package was not available on pip.org when your CI job started, but Conan 1.19.0 was there, so CPT crashed because it wasn't able to find a compatible version installed. Please, re-start that CI job, it should be fine now.

@aardappel
Copy link
Collaborator

@uilianries ah ok, so just a temporary de-sync, good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants