Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] LoRAParam inherits from Param #3988

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Makes LoRAParam inherit from Param. With this change LoRAParams are trained by default along with any other Param types on grad, value_and_grad and Optimizer.

@copybara-service copybara-service bot merged commit b5503da into main Jul 1, 2024
22 checks passed
@copybara-service copybara-service bot deleted the nnx-lora-param branch July 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants