Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retract breaking multi-module commit #288

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

morphar
Copy link
Collaborator

@morphar morphar commented Jan 10, 2022

This commit should be tagged as v0.6.3

This commit should be tagged as v0.6.3
@morphar morphar requested a review from a team as a code owner January 10, 2022 12:15
@morphar
Copy link
Collaborator Author

morphar commented Jan 10, 2022

@timburks as far as I understand, this pull request and #289 should fix the multi-module issues.

  1. merge Retract breaking multi-module commit #288
  2. create tags:
    cmd/report-messages/v0.6.3
    cmd/vocabulary-operations/v0.6.3
    cmd/report/v0.6.3
    cmd/protoc-gen-openapi/v0.6.3
    cmd/protoc-gen-jsonschema/v0.6.3
    cmd/petstore-builder/v0.6.3
    cmd/parse-linter-output/v0.6.3
    cmd/disco/v0.6.3
  3. merge Remove multi module #289
  4. tag v0.6.4

If this fixes the issues, it should probably have a release as well, right?

@morphar morphar marked this pull request as draft January 10, 2022 12:25
@morphar morphar marked this pull request as ready for review January 10, 2022 12:28
@timburks
Copy link
Contributor

@morphar Thank you!

@timburks timburks merged commit d9ddc71 into google:master Jan 22, 2022
@timburks
Copy link
Contributor

@morphar I am unable to create the cmd/ tags with the leading slash. Looking at your comment here, I think the leading slashes may have been added to your note above unintentionally. I'll proceed and create tags without the leading slash.

@morphar
Copy link
Collaborator Author

morphar commented Jan 22, 2022

@timburks You're absolutely right, the leading slash is wrong.
I have removed them from the comment, just to avoid confusion for anybody else reading it :)

@timburks
Copy link
Contributor

@morphar Thanks! The tags are pushed now, so I'll proceed with the next merge and tag.

@morphar
Copy link
Collaborator Author

morphar commented Jan 22, 2022

Nice! Thank you @timburks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants