all: update go-cmp to 0.3

[zombiezen]

Picks up improvements in diff output

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@a5a281f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1951   +/-   ##
=========================================
  Coverage          ?   77.65%           
=========================================
  Files             ?       81           
  Lines             ?     9392           
  Branches          ?        0           
=========================================
  Hits              ?     7293           
  Misses            ?     1578           
  Partials          ?      521

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a281f...7c2465c. Read the comment docs.

[vangent]

Where are all of the new dependencies in go.mod coming from? I don't trust go mod tidy.

[jba]

Agreed. Can you run some go mod why's, Ross? I'm particularly curious about why there are two different imports for rethinkDB.

[zombiezen]

Problems seem to boil down largely to Vault: #1958. I am not confident that this is the entirety of the problem, but it's creating enough noise that it's hard for me to gather more information about where the other go.mod requirements are coming from.

I'll walk back the go mod tidy and simply change the version, but I think we should get rid of this haunted graveyard ASAP.

[eliben]

I'll walk back the go mod tidy and simply change the version, but I think we should get rid of this haunted graveyard ASAP.

By this do you mean #886 or something else?

[zombiezen]

I mean that this PR will simply update the go-cmp dependency with no other changes.