Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement organization role assignments for both users and teams #3281

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

felixlut
Copy link
Contributor

resolves #3280

@felixlut
Copy link
Contributor Author

felixlut commented Sep 21, 2024

While working on this I noticed that the file naming is slightly off from how GitHub structures their API:s. There's a difference between repository roles and organization roles, but currently the orgs_custom_roles.go file is dealing with both (even before my changes). It should probably be split up into orgs_repo_roles.go and orgs_org_roles.go (or maybe flip the order to orgs_role_{org/repo}.go to keep the files "closer together"), similarily to integrations/terraform-provider-github#2224.

Leaving it up to the reviewer to decide if this should be done in this PR directly or in a separate one later

@gmlewis gmlewis changed the title feat: implement organization role assignments for both users and teams feat: Implement organization role assignments for both users and teams Sep 21, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 21, 2024

Leaving it up to the reviewer to decide if this should be done in this PR directly or in a separate one later

Please perform the reorganization in your next PR. Thank you!

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.96%. Comparing base (2b8c7fa) to head (93c9317).
Report is 120 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   97.72%   92.96%   -4.76%     
==========================================
  Files         153      171      +18     
  Lines       13390    11705    -1685     
==========================================
- Hits        13085    10882    -2203     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
Just a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo.

github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
github/orgs_custom_roles.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 21, 2024
felixlut and others added 3 commits September 22, 2024 10:45
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@felixlut
Copy link
Contributor Author

@gmlewis done!

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@tomfeigin tomfeigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Sep 23, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2024

Thank you, @tomfeigin !
Merging.

@gmlewis gmlewis merged commit eda7049 into google:master Sep 23, 2024
6 of 7 checks passed
@felixlut felixlut deleted the organization-role-assignments branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support assigning organization roles to teams and users
3 participants