Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support baseRole option for custom organization roles #3284

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Sep 22, 2024

Resolves #3283

Exactly the same as the custom repo role.

Docs for the endpoint

@felixlut felixlut marked this pull request as ready for review September 22, 2024 14:21
@felixlut felixlut changed the title support baseRole option for custom organization roles feat: Support baseRole option for custom organization roles Sep 22, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 22, 2024

Please run step 4 of CONTRIBUTING.md and push the changes to this PR for the tests to pass.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (2b8c7fa) to head (b86c354).
Report is 117 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3284      +/-   ##
==========================================
- Coverage   97.72%   92.94%   -4.78%     
==========================================
  Files         153      171      +18     
  Lines       13390    11669    -1721     
==========================================
- Hits        13085    10846    -2239     
- Misses        215      729     +514     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @felixlut !
LGTM.
Merging.

@gmlewis gmlewis merged commit 63c97e6 into google:master Sep 22, 2024
6 of 7 checks passed
@felixlut felixlut deleted the custom-org-role-base-role branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support creating an organization role with base role
2 participants