Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Fixed 'exp' handling in ID token #58

Merged
merged 1 commit into from
Apr 10, 2019

Conversation

sungjungk
Copy link
Contributor

It is a measure for issue #57.

Modification:
Change the way of ‘exp’ handling; from data.GetString(“exp”, &str_value) to data.GetScalar(“exp”, &int_value)

Result:
It will not happen the bug when receiving ID token value.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@sungjungk
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@sungjungk
Copy link
Contributor Author

@SurferJeffAtGoogle Could you check the issue?

@SurferJeffAtGoogle SurferJeffAtGoogle merged commit 3eeb584 into google:master Apr 10, 2019
@SurferJeffAtGoogle
Copy link
Contributor

Thank you for submitting this fix. I apologize for taking so long to review. It got lost my TODO list. 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants