Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding multi-arch support for linux/ppc64le in ml-metadata #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding multi-arch support for linux/ppc64le in ml-metadata #171

wants to merge 2 commits into from

Conversation

amitmukati-2604
Copy link

No description provided.

@lehrig lehrig mentioned this pull request Feb 15, 2023
Open
54 tasks
@lehrig
Copy link

lehrig commented Feb 15, 2023

Note that this PR is part of a greater effort to enable Kubeflow and all its dependencies for multiple processor architectures (we start with ppc64le): kubeflow/kubeflow#6684

@BrianSong
Copy link
Collaborator

Hi @lehrig, I have transferred to another team. Please reach out to @ryanpeters-google as he is the owner for MLMD OSS now.

@lehrig
Copy link

lehrig commented Mar 9, 2023

Alright, so @ryanpeters-google, are we good to proceed here?

@ryanpeters-google
Copy link
Collaborator

Due to an internal issue unrelated to the content of this PR, I am unable to test your change at this time. I am working to resolve the issue internally. Targeting Q2 for resolution.

@pranavpandit1
Copy link

@ryanpeters-google: Any updates on this request?
cc @lehrig @amitmukati-2604

XinranTang
XinranTang requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@XinranTang XinranTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :) Could you provide some end-to-end results to show how you are able to build MLMD on ppc64le platforms?

ml_metadata/tools/docker_server/Dockerfile
@@ -31,6 +31,7 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
unzip \
software-properties-common \
git \
openjdk-8-jdk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openjdk-8-jdk
openjdk-8-jdk \

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this dependency is needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this dependency because bazel binary for linux/ppc64le needs java.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinranTang - does that clarify your question?

@thesuperzapper
Copy link

thesuperzapper commented Dec 14, 2023 •
edited
Loading

I believe my PR #188 (for ARM64) could be extended with PPC64 support once merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehrig lehrig lehrig left review comments

@XinranTang XinranTang XinranTang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amitmukati-2604 @lehrig @BrianSong @ryanpeters-google @pranavpandit1 @thesuperzapper @XinranTang