Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 3 anisotropy tests as suggested by EricChadwick #4493

Closed
wants to merge 4 commits into from
Closed

add 3 anisotropy tests as suggested by EricChadwick #4493

wants to merge 4 commits into from

Conversation

bhouston
Copy link
Contributor

@bhouston bhouston commented Oct 3, 2023

Reference Issue

Fixes the missing anisotropy tests mentioned in this issue: #4486

This involved:

  • Ensuring that glTF-Sample-Assets repository in addition to the pre-existing glTF-Sample-Models (which is the deprecated model repository) is checked out locally and ignored in git. This is where the new models are sourced from.
  • Adding 3 anisotropy models to config.json: AnisotropyBarnLamp, AnisotropyRotationTest and AnisotropyStrengthTest.
  • Running the screenshot updater and including those results (except for the blank images, there is a bug with three-gpu-pathtracer) as part of this PR as goldens.

This was referenced Oct 3, 2023
Closed
Closed
@bhouston bhouston mentioned this pull request Oct 4, 2023
Open
elalish
elalish reviewed Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md
@@ -94,15 +94,15 @@ Alternative error:
! was unexpected at this time.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google/model-viewer@1.10.1 prepare: `if [ ! -L './shared-assets' ]; then ln -s ../shared-assets ./shared-assets; fi && ../shared-assets/scripts/fetch-khronos-gltf-samples.sh`
npm ERR! @google/model-viewer@1.10.1 prepare: `if [ ! -L './shared-assets' ]; then ln -s ../shared-assets ./shared-assets; fi && ../shared-assets/scripts/fetch-khronos-gltf-models.sh && && ../shared-assets/scripts/fetch-khronos-gltf-assets.sh`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take this opportunity to switch from the old sample-models repo to the new sample-assets repo instead of using both? The models are the same anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be okay if I switch from this custom git checkout method to the more standard git submodule method?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, that sounds great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #4534

packages/render-fidelity-tools/test/goldens/khronos-AnisotropyStrengthTest/babylon-golden.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do babylon/filament/sample-viewer support anisotropy yet? If so, we should update to latest versions and make new goldens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added Goldens for these other renderers in this PR!

Screenshot 2023-10-04 at 11 56 01 AM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was commenting on one of them, which clearly doesn't support anisotropy. My question is: if we update our package.json to their latest versions, do they already support it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a new PR here (#4535) to bring in the anisotropy tests here on top of my other PR. I've updated Babylon and Filament to the latest versions as well. Let me know if this meets you requirements.

...der-fidelity-tools/test/goldens/khronos-AnisotropyStrengthTest/gltf-sample-viewer-golden.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea what's causing those scrollbars to appear? I've seen them randomly for ages, but can't seem to repro on my machine. I assume it's some CSS bug somewhere... They're annoying because they mess up the metrics (not that they're terribly reliable anyway, but still).

packages/render-fidelity-tools/test/goldens/khronos-AnisotropyBarnLamp/babylon-golden.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a nice example of why rendering transparency to a transparent canvas shouldn't be ignored...

@bhouston bhouston mentioned this pull request Oct 24, 2023
Merged
@bhouston
Copy link
Contributor Author

Closing this PR as it has been made obsolete by these two new PRs:

@bhouston bhouston closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elalish elalish elalish left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhouston @elalish