Switch from vite to webpack #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edirect pages Fixes #543, but breaks auth when using the dev server. That limitation will be addressed in a later commit by switching from vite to webpack.
Instead just load data files using regular Node.js `fs` library.
This enables webworkers to perform asynchronous initialization before setting an `onmessage` handler, and avoids potential bundler-dependent issues wih lost messages.
jbms
force-pushed
the
fix-bundling
branch
5 times, most recently
from
9c22c17
to
03572e0
Compare
The main advantage of vite is that the dev-server avoids bundling, but this leads to a lot of inconsistency between the dev-server and bundled version. In particular, there did not seem to be any non-hacky way to override the path of the oauth redirect html pages when using the dev-server. Additionally, in practice the webpack dev-server is just as fast once the time spent by the browser loading the non-bundled sources is taken into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.