Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding json with Attachments #942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdve
Copy link
Contributor

@jdve jdve commented Aug 19, 2020

When using Attachments, we need to properly encode them into json to
share them outside. OutputToJSON handled this correctly, but both
MfgInspector and StationServer did not. Move TestRecordEncoder into
openhtf.util.json, so that it can be shared by all three. For
station_server, patch the tornado json encoder, so that all values being
sent to the client through tornado are properly encoded.


This change is Reviewable

@google-cla
Copy link

google-cla bot commented Aug 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jdve
Copy link
Contributor Author

jdve commented Aug 25, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Aug 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Aug 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jdve
Copy link
Contributor Author

jdve commented Aug 27, 2020

@googlebot I signed it!

openhtf/output/proto/mfg_event_converter.py Outdated Show resolved Hide resolved
openhtf/output/proto/mfg_event_converter.py Outdated Show resolved Hide resolved
openhtf/output/servers/station_server.py Outdated Show resolved Hide resolved
openhtf/util/json_encoder.py Show resolved Hide resolved
When using Attachments, we need to properly encode them into json to
share them outside. OutputToJSON handled this correctly, but both
MfgInspector and StationServer did not. Move TestRecordEncoder into
openhtf.util.json, so that it can be shared by all three.  For
station_server, patch the tornado json encoder, so that all values being
sent to the client through tornado are properly encoded.
@jdve
Copy link
Contributor Author

jdve commented Aug 27, 2020

Thanks @arsharma1 for the feedback! I've updated the PR as your requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants