Completely remove old AffectedCommit code. #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkedar
approved these changes
Mar 15, 2023
| @@ -520,12 +515,7 @@ def _do_update(self, source_repo, repo, vulnerability, relative_path, | |||
|
|
|||
| bug.put() | |||
|
|
|||
| # Temporary migration exclusion: Don't write legacy Linux AffectedComit | |||
| # entries as they cause Datastore scaling issues. | |||
| write_legacy = not _is_linux_ecosystem(vulnerability) | |||
There was a problem hiding this comment.
Should _is_linux_ecosystem() also be removed?
There was a problem hiding this comment.
Good catch, removed!
docker/worker/worker_test.py
Outdated
Comment on lines
148
to
156
| should_be_deleted = osv.AffectedCommit( | ||
| id='OSV-2020-1337-abcd', | ||
| bug_id='OSV-2020-1337', | ||
| commit='abcd', | ||
| project='project', | ||
| ecosystem='ecosystem', | ||
| public=False) | ||
| should_be_deleted.put() | ||
|
|
There was a problem hiding this comment.
Is there no equivalent new version of this?
(I don't really know what this was testing...)
There was a problem hiding this comment.
Good catch, this was just checking if the new analysis overwrites previous results. I'll add the new equivalent here and a comment to explain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #951.