This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
gpioreg: Remove ByNumber() #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is still possible to get a pin by its logical number using the string representation, but the function is not exported anymore. This simplifies the interface, one less way to do the same thing.
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 84.63% 84.63% +<.01%
==========================================
Files 61 61
Lines 4854 4850 -4
==========================================
- Hits 4108 4105 -3
Misses 672 672
+ Partials 74 73 -1
Continue to review full report at Codecov.
|
mattetti
approved these changes
Aug 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is still possible to get a pin by its logical number using the string
representation, but the function is not exported anymore.
This simplifies the interface, one less way to do the same thing.