This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
unit strings rounding todo #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement rounding for nanoAsString and microAsString. add rounding test cases for nanoAsString. add rounding test cases for microAsString. fix examples for unit rounding.
maruel
reviewed
Oct 14, 2018
add test case for microAsString change +1 to ++ in microAsString
|
gohci |
|
I've confirmed with |
|
Thanks a lot for this excellent PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the way physic units represented as string.
implement rounding for nanoAsString and microAsString.
add rounding test cases for nanoAsString.
add rounding test cases for microAsString.
fix examples for unit rounding.