-
Notifications
You must be signed in to change notification settings - Fork 167
mcp23xxx: support for Microchip MCP23 family of IO extenders #433
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Sorry for the delay. I can't approve because both the CLA checker and Travis failed. For the CLA checker, see the instructions above. For travis, if you click through, you'll end up on https://travis-ci.org/google/periph/jobs/653761040 and scrolling a bit you'll find the red text:
Basically, run gofmt -s on the new files and it should do a small number of modifications. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 63.51% 63.36% -0.15%
==========================================
Files 117 120 +3
Lines 12187 12425 +238
==========================================
+ Hits 7740 7873 +133
- Misses 4249 4344 +95
- Partials 198 208 +10
Continue to review full report at Codecov.
|
gohci |
Could you fix some of the comments? In practice the copyright one is the one I care the most about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. I had forgotten to press submit review. My apologies.
experimental/devices/mcp23xxx/doc.go
Outdated
// Package mcp23xxx controls IO extenders belonging to Microchip MCP23 family | ||
// | ||
// Supported variants: | ||
// * MCP23008/MCP23S08 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will show up weirdly in godoc. You can confirm with godoc -http=:8080
then browsing to http://localhost:8080/pkg/periph.io/x/periph/experimental/devices/mcp23xxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I removed this list from here and tried to document the supported variants at the appropriate constant declarations, although godoc doesn't render the comments there. Do you have any suggestions?
gohci |
Thanks! |
This driver supports the following I2C and SPI IO extenders:
The driver is still under development, Interrupt support is not yet implemented.