Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

devices/tlv493d: Implement TLV493D hall effect sensor on I2C bus #450

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

bezineb5
Copy link
Contributor

Implemented Infineon TLV493D, a 3-dimensional hall effect sensor:
https://www.infineon.com/cms/en/product/sensor/magnetic-sensors/magnetic-position-sensors/3d-magnetics/tlv493d-a1b6/
This is also available through Adafruit: https://www.adafruit.com/product/4366

I tried to be comprehensive in the implementation, trying to cover use cases ranging from ultra-low-power to high frequency with low precision required.

I've not included in this PR a higher-level filter to measure an angle (typical application for this sensor, see https://www.infineon.com/dgdl/Infineon-3D_Magnetic_Sensor_for_Angle_Measurements-AN-v01_10-AN-v01_01-EN.pdf?fileId=5546d46265f064ff01665a3d22f055e3) - I didn't include it as I think it's beyond the scope of periph.io, and it's full of floats. Is there any interest in such thing?

Also, I'll try to add that in the documentation (as well as the long overdue ADS1x15... sorry for that)

Thanks!
Benjamin

@bezineb5 bezineb5 force-pushed the tlv493d branch 2 times, most recently from 2540fd2 to da23497 Compare October 28, 2020 15:43
@maruel
Copy link
Contributor

maruel commented Oct 28, 2020

gohci

Copy link
Contributor

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks great, only minor nits, nothing really blocking.

I just want to update the static file as a separate change first, then this can be committed.

experimental/cmd/tlv493d/main.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/doc.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/doc.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/example_test.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/tlv493d.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/tlv493d.go Outdated Show resolved Hide resolved
experimental/devices/tlv493d/tlv493d_test.go Outdated Show resolved Hide resolved
@bezineb5
Copy link
Contributor Author

Thanks for the comments! I fixed the typos.

@maruel
Copy link
Contributor

maruel commented Nov 1, 2020

Thanks for the PR and apologies for the delay.

@maruel maruel merged commit 8ecebda into google:master Nov 1, 2020
@bezineb5 bezineb5 deleted the tlv493d branch November 1, 2020 23:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants