Skip to content

Commit

Permalink
Dispatch setConfiguredAudiences appropriately.
Browse files Browse the repository at this point in the history
Fix param name.
  • Loading branch information
hussain-t committed Jul 3, 2024
1 parent a32b53c commit 2daea42
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions assets/js/modules/analytics-4/datastore/audiences.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,10 @@ const baseActions = {
* @since 1.128.0
* @since n.e.x.t Added `failedSiteKitAudienceSlugs` parameter to retry failed Site Kit audience creation.
*
* @param {Array} failedSiteKitAudienceSlugs List of failed Site Kit audience slugs to retry.
* @param {Array} createdSiteKitAudienceSlugs List of successfully created Site Kit audience slugs.
* @param {Array} failedSiteKitAudienceSlugs List of failed Site Kit audience slugs to retry.
* @return {Object} Object with `failedSiteKitAudienceSlugs`, `createdSiteKitAudienceSlugs` and `error`.
*/
*enableAudienceGroup(
failedSiteKitAudienceSlugs,
createdSiteKitAudienceSlugs = []
) {
*enableAudienceGroup( failedSiteKitAudienceSlugs ) {
const registry = yield commonActions.getRegistry();

const { dispatch, select, __experimentalResolveSelect } = registry;
Expand Down Expand Up @@ -293,28 +289,32 @@ const baseActions = {
);

const failedAudiencesToRetry = [];
// const createdAudiences = [];
const createdAudiences = [ ...createdSiteKitAudienceSlugs ];

audienceCreationResults.forEach( ( result, index ) => {
const audienceSlug = audiencesToCreate[ index ];
if ( result.error ) {
failedAudiencesToRetry.push( audienceSlug );
} else {
createdAudiences.push( result.response.name );
configuredAudiences.push( result.response.name );
}
} );

const existingConfiguredAudiences =
select( MODULES_ANALYTICS_4 ).getConfiguredAudiences() || [];

configuredAudiences.push( ...existingConfiguredAudiences );

// If the audiences were created successfully, set them as configured audiences.
dispatch( MODULES_ANALYTICS_4 ).setConfiguredAudiences(
configuredAudiences
);

if ( failedAudiencesToRetry.length > 0 ) {
return {
failedSiteKitAudienceSlugs: failedAudiencesToRetry,
createdSiteKitAudienceSlugs: createdAudiences,
};
}

// Add created audiences to configured audiences.
configuredAudiences.push( ...createdAudiences );

// Resync available audiences to ensure the newly created audiences are available.
yield commonActions.await(
dispatch( MODULES_ANALYTICS_4 ).syncAvailableAudiences()
Expand Down

0 comments on commit 2daea42

Please sign in to comment.