Skip to content

Commit

Permalink
Address additional actionlint issues in zips.yml.
Browse files Browse the repository at this point in the history
  • Loading branch information
benbowler committed Jul 1, 2024
1 parent 6bd6134 commit 8b2a100
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/zips.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ jobs:
- name: Build develop version
run: |
npm run dev-zip
mv *.zip "${{ github.ref }}/google-site-kit-dev.zip"
mv ./*.zip "${{ github.ref }}/google-site-kit-dev.zip"
- name: Build release version
run: |
npm run release-zip
mv *.zip "${{ github.ref }}/google-site-kit.zip"
mv ./*.zip "${{ github.ref }}/google-site-kit.zip"
- name: Upload artifacts
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -166,15 +166,17 @@ jobs:
- name: Get comment body
id: get-comment-body
# Setting a multi-line output requires escaping line-feeds. See <https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings>.
# shellcheck disable=SC2129,SC2086

run: |

Check failure on line 170 in .github/workflows/zips.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/zips.yml#L170

shellcheck reported issue in this script: SC1083:warning:5:6: This { is literal. Check expression (missing ;/\n?) or quote it [shellcheck]
Raw output
.github/workflows/zips.yml:170:9: shellcheck reported issue in this script: SC1083:warning:5:6: This { is literal. Check expression (missing ;/\n?) or quote it [shellcheck]

Check failure on line 170 in .github/workflows/zips.yml

View workflow job for this annotation

GitHub Actions / actionlint

[actionlint] .github/workflows/zips.yml#L170

shellcheck reported issue in this script: SC1089:error:9:1: Parsing stopped here. Is this keyword correctly matched up? [shellcheck]
Raw output
.github/workflows/zips.yml:170:9: shellcheck reported issue in this script: SC1089:error:9:1: Parsing stopped here. Is this keyword correctly matched up? [shellcheck]
body="Build files for ${{ github.event.pull_request.head.sha }} are ready:
- Download [development build](https://storage.googleapis.com/${{ env.GCS_BUCKET }}/${{ env.GCS_ROOT_PATH }}/${{ github.ref }}/google-site-kit-dev.zip?${{ github.sha }})
- Download [production build](https://storage.googleapis.com/${{ env.GCS_BUCKET }}/${{ env.GCS_ROOT_PATH }}/${{ github.ref }}/google-site-kit.zip?${{ github.sha }})"
delimiter="${body//$'\n'/'%0A'}"
echo "body<<${delimiter}" >> $GITHUB_OUTPUT
echo "$body" >> $GITHUB_OUTPUT
echo "${delimiter}" >> $GITHUB_OUTPUT
echo {
"body<<${delimiter}"
"$body"
"${delimiter}"
} >> "$GITHUB_OUTPUT"
- name: Create comment on PR with links to build files
if: ${{ steps.find-comment.outputs.comment-id == '' }}
uses: peter-evans/create-or-update-comment@v4
Expand Down

0 comments on commit 8b2a100

Please sign in to comment.