Merge pull request #8983 from google/bug/8763-audience-tile-data-vali…

…dity Correct metrics and metric formatting on Audience Tiles.
google · Jul 8, 2024 · c32a34d · c32a34d
2 parents 9489c18 + d1bb3f7
commit c32a34d
Show file tree

Hide file tree

Showing 33 changed files with 9 additions and 2 deletions.
diff --git a/...ics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTileCitiesMetric.js b/...ics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTileCitiesMetric.js
@@ -58,7 +58,8 @@ export default function AudienceTileCitiesMetric( {
 								</div>
 								<div className="googlesitekit-audience-segmentation-tile-metric__cities-metric-value">
 									{ numFmt(
-										topCities?.metricValues[ index ]?.value,
+										topCities?.metricValues[ index ]
+											?.value / topCities?.total,
 										{
 											style: 'percent',
 											maximumFractionDigits: 1,

diff --git a/...analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTileMetric.js b/...analytics-4/components/audience-segmentation/dashboard/AudienceTile/AudienceTileMetric.js
@@ -31,6 +31,7 @@ export default function AudienceTileMetric( {
 	title,
 	metricValue,
 	Badge,
+	metricValueFormat,
 } ) {
 	return (
 		<div className="googlesitekit-audience-segmentation-tile-metric">
@@ -39,7 +40,7 @@ export default function AudienceTileMetric( {
 			</div>
 			<div className="googlesitekit-audience-segmentation-tile-metric__container">
 				<div className="googlesitekit-audience-segmentation-tile-metric__value">
-					{ numFmt( metricValue ) }
+					{ numFmt( metricValue, metricValueFormat ) }
 				</div>
 				<div className="googlesitekit-audience-segmentation-tile-metric__title">
 					{ title }
@@ -57,4 +58,5 @@ AudienceTileMetric.propTypes = {
 	title: PropTypes.string.isRequired,
 	metricValue: PropTypes.number.isRequired,
 	Badge: PropTypes.elementType.isRequired,
+	metricValueFormat: PropTypes.object,
 };
diff --git a/...s/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/index.js b/...s/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTile/index.js
@@ -219,6 +219,10 @@ export default function AudienceTile( {
 								currentValue={ pagesPerVisit.currentValue }
 							/>
 						) }
+						metricValueFormat={ {
+							style: 'decimal',
+							maximumFractionDigits: 2,
+						} }
 					/>
 
 					<AudienceTileMetric

diff --git a/...eSegmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_0_small.png b/...eSegmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_0_small.png
diff --git a/...Segmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_1_medium.png b/...Segmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_1_medium.png
diff --git a/...eSegmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_2_large.png b/...eSegmentation_Dashboard_AudienceTile_AudiencePartialData_0_document_2_large.png
diff --git a/...ceSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_0_small.png b/...ceSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_0_small.png
diff --git a/...eSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_1_medium.png b/...eSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_1_medium.png
diff --git a/...ceSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_2_large.png b/...ceSegmentation_Dashboard_AudienceTile_ReadyLongCityNames_0_document_2_large.png
diff --git a/...udienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_0_small.png b/...udienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_0_small.png
diff --git a/...dienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_1_medium.png b/...dienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_1_medium.png
diff --git a/...udienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_2_large.png b/...udienceSegmentation_Dashboard_AudienceTile_ReadyViewOnly_0_document_2_large.png
diff --git a/...enceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_0_small.png b/...enceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_0_small.png
diff --git a/...nceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_1_medium.png b/...nceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_1_medium.png
diff --git a/...enceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_2_large.png b/...enceSegmentation_Dashboard_AudienceTile_ReadyWithToolTip_0_document_2_large.png
diff --git a/...onents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_0_small.png b/...onents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_0_small.png
diff --git a/...nents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_1_medium.png b/...nents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_1_medium.png
diff --git a/...onents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_2_large.png b/...onents_AudienceSegmentation_Dashboard_AudienceTile_Ready_0_document_2_large.png
diff --git a/...egmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_0_small.png b/...egmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_0_small.png
diff --git a/...gmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_1_medium.png b/...gmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_1_medium.png
diff --git a/...egmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_2_large.png b/...egmentation_Dashboard_AudienceTile_TopContentPartialData_0_document_2_large.png
diff --git a/...tation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_0_small.png b/...tation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_0_small.png
diff --git a/...ation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_1_medium.png b/...ation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_1_medium.png
diff --git a/...tation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_2_large.png b/...tation_Dashboard_AudienceTilesWidget_DefaultWithZeroTile_0_document_2_large.png
diff --git a/...dienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_0_small.png b/...dienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_0_small.png
diff --git a/...ienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_1_medium.png b/...ienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_1_medium.png
diff --git a/...dienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_2_large.png b/...dienceSegmentation_Dashboard_AudienceTilesWidget_Default_0_document_2_large.png
diff --git a/...ation_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_0_small.png b/...ation_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_0_small.png
diff --git a/...tion_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_1_medium.png b/...tion_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_1_medium.png
diff --git a/...ation_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_2_large.png b/...ation_Dashboard_AudienceTilesWidget_TwoTilesWithZeroTile_0_document_2_large.png
diff --git a/...ienceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_0_small.png b/...ienceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_0_small.png
diff --git a/...enceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_1_medium.png b/...enceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_1_medium.png
diff --git a/...ienceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_2_large.png b/...ienceSegmentation_Dashboard_AudienceTilesWidget_TwoTiles_0_document_2_large.png