Issue / 8777 Prevent Conversion Tracking When Toggled Off #8779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion tracking toggled off.
…ion_Tracking::register().
…pt enqueued when conversion tracking disabled.
|
Build files for a461c55 have been deleted. |
zutigrm
requested changes
May 31, 2024
…scripts callback.
zutigrm
approved these changes
May 31, 2024
aaemnnosttv
requested changes
May 31, 2024
There was a problem hiding this comment.
Thanks @10upsimon – this LGTM, just a few small changes to clean this up.
| @@ -96,7 +96,7 @@ public function register() { | |||
| 'wp_enqueue_scripts', | |||
| function() { | |||
| // Do nothing if neither Ads nor Analytics snippet has been inserted. | |||
| if ( ! did_action( 'googlesitekit_ads_init_tag' ) && ! did_action( 'googlesitekit_analytics-4_init_tag' ) ) { | |||
| if ( ! $this->conversion_tracking_settings->is_conversion_tracking_enabled() || ( ! did_action( 'googlesitekit_ads_init_tag' ) && ! did_action( 'googlesitekit_analytics-4_init_tag' ) ) ) { | |||
There was a problem hiding this comment.
Let's split these onto separate lines as it's quite hard to read as one long line especially with extra parenthesis.
Also, the implementation is getting a bit large to be inline here, let's extract it to a method to keep register focused on just registration.
Comment on lines
63
to
67
| $original_conversion_tracking_settings = array( | ||
| 'enabled' => true, | ||
| ); | ||
|
|
||
| $this->conversion_tracking_settings->set( $original_conversion_tracking_settings ); |
There was a problem hiding this comment.
This shouldn't be needed since changes to options shouldn't persist between tests as WP will rollback the transaction. Feel free to double check to make sure though 👍
Comment on lines
80
to
84
| $original_conversion_tracking_settings = array( | ||
| 'enabled' => false, | ||
| ); | ||
|
|
||
| $this->conversion_tracking_settings->set( $original_conversion_tracking_settings ); |
There was a problem hiding this comment.
How about this?
Suggested change
| $original_conversion_tracking_settings = array( | |
| 'enabled' => false, | |
| ); | |
| $this->conversion_tracking_settings->set( $original_conversion_tracking_settings ); | |
| $this->conversion_tracking_settings->set( array( 'enabled' => false ) ); |
aaemnnosttv
approved these changes
May 31, 2024
aaemnnosttv
deleted the
issue/8777-prevent-conversion-tracking-when-toggled-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
Conversion_TrackingTestto add test that asserts scripts are not enqueued when conversion tracking is disabled.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist