Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @wordpress/data to version 4.27.3 #8891

Merged
merged 15 commits into from
Jul 4, 2024

Conversation

kuasha420
Copy link
Collaborator

@kuasha420 kuasha420 commented Jun 18, 2024

Summary

Addresses issue:

Relevant technical choices

The IB calls for additional test coverage, but it proved too difficult to create test cases and test reliably in isolation without a lot of repetitive messy code, test components and registry provider, since the behavior depends on the useSelect hook and not the select function itself.

All our existing tests, which where failing without the patch previously are now passing, so this can be taken as good indication of the robustness. However, feedback welcome if we can introduce additional testing without a lot of repetitive code.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@kuasha420 kuasha420 marked this pull request as ready for review June 28, 2024 23:46
Copy link

github-actions bot commented Jun 28, 2024

Build files for 5ef4f9c have been deleted.

Copy link

Size Change: +2.87 kB (+0.18%)

Total Size: 1.56 MB

Filename Size Change
./dist/assets/js/34-********************.js 3.11 kB -1 B (-0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 24 kB -4 B (-0.02%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.4 kB +1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.8 kB -11 B (-0.03%)
./dist/assets/js/googlesitekit-api-********************.js 10.2 kB -4 B (-0.04%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB -3 B (-0.05%)
./dist/assets/js/googlesitekit-data-********************.js 2.36 kB +1 B (+0.04%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB +2 B (+0.1%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB -28 B (-0.14%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB -31 B (-0.12%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 74 kB -3 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 123 kB +8 B (+0.01%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -55 B (-0.25%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB -23 B (-0.08%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB +3 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 143 kB -48 B (-0.03%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB -16 B (-0.07%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.5 kB -347 B (-0.59%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.1 kB -9 B (-0.03%)
./dist/assets/js/googlesitekit-settings-********************.js 61.6 kB +3 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 72.9 kB +27 B (+0.04%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.2 kB +27 B (+0.06%)
./dist/assets/js/googlesitekit-vendor-********************.js 320 kB +3.39 kB (+1.07%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB -4 B (-0.01%)
./dist/assets/js/runtime-********************.js 1.3 kB +1 B (+0.08%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.1 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.76 kB
./dist/assets/js/30-********************.js 2.25 kB
./dist/assets/js/31-********************.js 3.64 kB
./dist/assets/js/32-********************.js 935 B
./dist/assets/js/33-********************.js 892 B
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/contact-form-7-********************.js 645 B
./dist/assets/js/easy-digital-downloads-********************.js 615 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-widgets-********************.js 60.7 kB
./dist/assets/js/mailchimp-********************.js 629 B
./dist/assets/js/ninja-forms-********************.js 727 B
./dist/assets/js/optin-monster-********************.js 673 B
./dist/assets/js/popup-maker-********************.js 634 B
./dist/assets/js/woocommerce-********************.js 652 B
./dist/assets/js/wpforms-********************.js 632 B

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @kuasha420, it's so good to move this along and unblock further package upgrades. 🌶️ 🎉

@techanvil techanvil merged commit d1f8bea into develop Jul 4, 2024
21 checks passed
@techanvil techanvil deleted the hackathon/wordpress-data-upgrade branch July 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants