Upgrade PHPCS standards and fix issues, excluding ExceptionNotEscaped.

[benbowler]

Summary

Addresses issue:

• Upgrade PHPCS standards #8724

Relevant technical choices

I updated the suggested packages and their dependencies, then worked through many new fixes and addressed them using lint-fix and manually.

The only rule that I suggest we address in a follow up issue is WordPress.Security.EscapeOutput.ExceptionNotEscaped, which I've disabled here for now. There are many examples where we return variables in our error response strings. As mentioned in this thread, the security impact here is for uncaught/handled errors for:

people having display_errors on (which is PHP's default) and html_errors off (which is not the default)

In our usage we may be able to skip many of these where the errors are part of REST endpoints where the response won't be rendered in the users site/plugin dashboard. Other core plugin exceptions should perhaps be escaped incase they are left uncaught and could return unescaped html on the plugin dashboard. Generally creating a new ticket will allow us to evaluate the possible impact through the AC/IB process.

Alternatively if we are clear that each error is correctly handled by the plugin we can permanently disable this rule.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for e5e7835 have been deleted.

[tofumatt]

Looks good to me, just a merge conflict that needs to be resolved (sorry I took awhile to review this one, but after that should be good-to-go 😄)

I removed the QA Brief since it was really just a request for another code review, which I don't think is needed 😄

[techanvil]

Hey @benbowler @tofumatt, this change is an error, and Site Kit is being rejected by the SKS during setup as a result.

This line, and the corresponding update to Google_ProxyTest.php need to be reverted.