-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spacing between Audience widget area and other widget areas. #8961
Conversation
Build files for c4cdd12 have been deleted. |
Size Change: +28 B (0%) Total Size: 1.55 MB
ℹ️ View Unchanged
|
@media (min-width: $width-desktop + 1 + px) { | ||
padding-top: 8px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a breakpoint for desktop here:
site-kit-wp/assets/sass/config/_variables.scss
Lines 272 to 278 in 08388e7
$bp-xsmallOnly: $width-xsmall - 1 + px; | |
$bp-mobileOnly: $width-tablet - 1 + px; | |
$bp-tablet: $width-tablet + px; | |
$bp-nonMobile: $width-tablet + 1 + px; | |
$bp-nonTablet: $width-desktop + 1 + px; | |
$bp-wpAdminBarTablet: $width-wpAdminBarTablet + px; | |
$bp-desktop: $width-desktop + px; |
Looks like it doesn't have the + 1
that most other breakpoints have, which is maybe why we have so many (min-width: $width-desktop + 1 + px)
s in the codebase:
I've filed #8964 to address it, since it's out-of-scope here and will be a bigger change 😄
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist