Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #8870 from google/enhancement/8726-pivot-report-audience-tiles #8969

Merged

Conversation

techanvil
Copy link
Collaborator

@techanvil techanvil commented Jul 5, 2024

Summary

Revert the previous PR for #8726 as the pivot reports are not giving the desired results for the audience tiles.

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

…eport-audience-tiles"

This reverts commit 0beeecd, reversing
changes made to 8240ccf.
Copy link

github-actions bot commented Jul 5, 2024

Build files for 8f873c3 have been deleted.

Copy link

github-actions bot commented Jul 5, 2024

Size Change: -823 B (-0.05%)

Total Size: 1.57 MB

Filename Size Change
./dist/assets/js/35-********************.js 3.12 kB +1 B (+0.03%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.5 kB -7 B (-0.01%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.8 kB -8 B (-0.02%)
./dist/assets/js/googlesitekit-api-********************.js 10.2 kB -3 B (-0.03%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.36 kB +1 B (+0.04%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB -2 B (-0.1%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB +5 B (+0.03%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB +1 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 74.1 kB -1 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 124 kB -281 B (-0.23%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB -6 B (-0.02%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 113 kB -7 B (-0.01%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 144 kB -158 B (-0.11%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +10 B (+0.04%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 11.3 kB -4 B (-0.04%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.4 kB -15 B (-0.03%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB -9 B (-0.03%)
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB -2 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 73.4 kB +13 B (+0.02%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.3 kB +2 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 320 kB -2 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 62 kB -340 B (-0.55%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB -8 B (-0.01%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 55.1 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/30-********************.js 2.76 kB
./dist/assets/js/31-********************.js 2.25 kB
./dist/assets/js/32-********************.js 3.64 kB
./dist/assets/js/33-********************.js 935 B
./dist/assets/js/34-********************.js 892 B
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.13 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 645 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 615 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 629 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 727 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 673 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 652 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 632 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to reiterate, this PR reverts all the changes made by #8870. This could be committed directly to develop, but since it is quite a large change, we're doing it as a separate PR.

I've double-checked this PR and it doesn't contain any unrelated changes apart from the intended revert.

LGTM 👍

@nfmohit nfmohit merged commit 3c84c6f into develop Jul 5, 2024
20 of 21 checks passed
@nfmohit nfmohit deleted the enhancement/8726-pivot-report-audience-tiles-revert branch July 5, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants