Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding liberty file generation #34

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Adding liberty file generation #34

merged 5 commits into from
Jul 6, 2020

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Jul 2, 2020 •
edited
Loading

By typing make timing liberty files will be generated from the timing data found in the json files.

Fixes #6 and #8

Signed-off-by: Tim 'mithro' Ansell tansell@google.com

@mithro
Copy link
Contributor Author

mithro commented Jul 2, 2020

This pull request depends on #33.

@mithro mithro added lib-sky130_fd_sc_hd Issues with the "high density" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_hdll Issues with the "high density low leakage" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_hs Issues with the "high speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ms Issues with the "medium speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ls Issues with the "low speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_lp Issues with the "low power" digital standard cells provided by the SkyWater foundry. scripts-python Issues with the Python scripts provided as part of the PDK. tools-Cadence-Innovus Issues with using Cadence Innovus with the PDK. tools-OpenROAD Issues with using OpenROAD with the PDK. labels Jul 2, 2020
@mithro mithro requested a review from msaligane July 2, 2020 00:41
msaligane
msaligane reviewed Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@msaligane msaligane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sky130_fd_sc_lp and sky130_fd_sc_hvl are still failing during .lib.json to .lib conversion. Please check related github bugs:
https://github.com/mithro/skywater-pdk-audit/issues/259#issuecomment-652721800

Note: this is using the openroad flow only. Checks using commercial tools are still in-progress.

@mithro
Copy link
Contributor Author

mithro commented Jul 2, 2020

So I can merge the other libraries, I'll move the sky130_fd_sc_lp and sky130_fd_sc_hvl libraries into a seperate pull request.

@mithro mithro force-pushed the liberty branch 2 times, most recently from cee0c2d to 1ca4b1e Compare July 2, 2020 02:47
@mithro mithro added the type-enhancement New feature or request label Jul 2, 2020
@mithro
Copy link
Contributor Author

mithro commented Jul 2, 2020

I have moved the sky130_fd_sc_lp and sky130_fd_sc_hvl standard cells into the pull request at #35

@mithro mithro linked an issue Jul 2, 2020 that may be closed by this pull request
Publish script which recombined the individual cell liberty files into a single liberty library #8
Closed
@probot-autolabeler probot-autolabeler bot added documentation Improvements or additions to documentation files-model-behavioral-verilog Issues related to the Verilog behavioural models. files-model-functional-verilog Issues related to the Verilog functional models. files-powerpins Issues related to the version of files which include power pins. files-schematic-svg Issues related to schematic files. files-symbol-svg Issues related to symbol files. files-symbol-verilog Issues related to the Verilog symbol definition. labels Jul 4, 2020
@mithro mithro requested a review from msaligane July 4, 2020 07:22
@mithro
Copy link
Contributor Author

mithro commented Jul 4, 2020

@msaligane - This should fix the liberty issues you were having. Could you check?

@mithro
Copy link
Contributor Author

mithro commented Jul 5, 2020

@msaligane - I opened #57, #58 and #56 for the remaining issues you found.

mithro and others added 5 commits July 6, 2020 06:36
@mithro
api: Adding corners processing.
f253344 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro
api: Fix parsing cell name.
45580cb 
Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro
api: Adding liberty file generator.
74273c4 
Generates liberty timing files from the included json timing data.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro
api: Ignore generated timing/*.lib files.
ad9a4a4 
Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro
api: Change the way liberty attributes are sorted.
ee77597 
Fixes google#37, google#40.

The `LIBERTY_ATTRIBUTE_ORDER` template is used to control the ordering
of the liberty attribute output.

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro mithro merged commit b1fc6a7 into google:master Jul 6, 2020
@mithro mithro deleted the liberty branch July 6, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaligane msaligane Awaiting requested review from msaligane

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation files-model-behavioral-verilog Issues related to the Verilog behavioural models. files-model-functional-verilog Issues related to the Verilog functional models. files-powerpins Issues related to the version of files which include power pins. files-schematic-svg Issues related to schematic files. files-symbol-svg Issues related to symbol files. files-symbol-verilog Issues related to the Verilog symbol definition. lib-sky130_fd_sc_hd Issues with the "high density" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_hdll Issues with the "high density low leakage" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_hs Issues with the "high speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_lp Issues with the "low power" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ls Issues with the "low speed" digital standard cells provided by the SkyWater foundry. lib-sky130_fd_sc_ms Issues with the "medium speed" digital standard cells provided by the SkyWater foundry. scripts-python Issues with the Python scripts provided as part of the PDK. tools-Cadence-Innovus Issues with using Cadence Innovus with the PDK. tools-OpenROAD Issues with using OpenROAD with the PDK. type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@mithro @msaligane