Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/docker: Install bazel from the official bazel repo #2708

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

avagin
Copy link
Collaborator

@avagin avagin commented Aug 13, 2021

The debian repo contains an old version and it can't build gVisor:
external/rules_pkg/private/pkg_files.bzl:315:12: name 'json' is not defined

@avagin avagin requested a review from dvyukov August 13, 2021 00:58
@google-cla
Copy link

google-cla bot commented Aug 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Aug 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@avagin avagin force-pushed the docker branch 2 times, most recently from ad2d024 to f4052b2 Compare August 13, 2021 05:19
The debian repo contains an old version and it can't build gVisor:
external/rules_pkg/private/pkg_files.bzl:315:12: name 'json' is not defined

Signed-off-by: Andrei Vagin <avagin@google.com>
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #2708 (673c1d0) into master (3fd2ea6) will not change coverage.
The diff coverage is n/a.

@dvyukov
Copy link
Collaborator

dvyukov commented Aug 13, 2021

Were you able to build the container? It worked initially, but then I remember there were some issues (unrelated to bazel, just broken debian).

@avagin
Copy link
Collaborator Author

avagin commented Aug 13, 2021

I can build it on my workstation without any issues:

$ docker build -f tools/docker/syzbot/Dockerfile .
Sending build context to Docker daemon  484.3MB
Step 1/8 : FROM debian:bullseye
 ---> 70f2a6b47821
Step 2/8 : RUN apt-get update
 ---> Using cache
 ---> ccbfe7fc77ec
Step 3/8 : RUN DEBIAN_FRONTEND=noninteractive apt-get install -y -q 	gcc g++ binutils make ccache golang-go 	clang clang-format clang-tidy 	unzip curl sudo procps psmisc nano vim git bzip2 dh-autoreconf software-properties-common 	flex bison bc gawk dwarves cpio texinfo texi2html lzop lbzip2 	zlib1g-dev libelf-dev libncurses-dev libmpc-dev libssl-dev 	qemu-user 	qemu-utils qemu-system-misc qemu-system-x86 qemu-system-arm qemu-system-aarch64  	qemu-system-s390x qemu-system-mips qemu-system-ppc 	g++-arm-linux-gnueabi g++-aarch64-linux-gnu g++-powerpc64le-linux-gnu 	g++-mips64el-linux-gnuabi64 g++-s390x-linux-gnu g++-riscv64-linux-gnu 	libc6-dev-i386 libc6-dev-i386-amd64-cross lib32gcc-10-dev lib32stdc++-10-dev 	apt-transport-https curl gnupg python-is-python3
 ---> Using cache
 ---> 8e91de1ce8c5
Step 4/8 : RUN mkdir -p /usr/grte/v5/bin && ln -s /usr/bin/python3 /usr/grte/v5/bin/python2.7
 ---> Using cache
 ---> e856c20d52fe
Step 5/8 : RUN echo "deb [arch=amd64] http://storage.googleapis.com/bazel-apt stable jdk1.8" | 	sudo tee /etc/apt/sources.list.d/bazel.list && 	curl https://bazel.build/bazel-release.pub.gpg | sudo apt-key add -
 ---> Using cache
 ---> 04de0539b877
Step 6/8 : RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y -q bazel
 ---> Using cache
 ---> 1a5abf0e6746
Step 7/8 : RUN useradd syzkaller
 ---> Using cache
 ---> 1e2dbf04d242
Step 8/8 : RUN echo "export PS1='\n\W🤖 '" >> /root/.bashrc
 ---> Using cache
 ---> 019dac878857
Successfully built 019dac878857

@dvyukov dvyukov requested a review from a-nogikh August 14, 2021 08:23
@dvyukov
Copy link
Collaborator

dvyukov commented Aug 14, 2021

I can build it on my workstation without any issues:

That's good!
The change looks good to me. @a-nogikh will deploy it next week. Here are the instructions:
https://github.com/google/syzkaller/blob/master/tools/docker/README.md

@a-nogikh
Copy link
Collaborator

I've built and uploaded the new docker image.

@a-nogikh a-nogikh merged commit 6652437 into google:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants