Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: ifconfig destroy wants the interface (not device) name #2739

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

blackgnezdo
Copy link
Collaborator

At least on OpenBSD this is the behavior:
% doas ifconfig tun5 create
% doas ifconfig tun5 destroy
% doas ifconfig tun5 create
% doas ifconfig /dev/tun5 destroy
ifconfig: SIOCIFDESTROY: Invalid argument

At least on OpenBSD this is the behavior:
% doas ifconfig tun5 create
% doas ifconfig tun5 destroy
% doas ifconfig tun5 create
% doas ifconfig /dev/tun5 destroy
ifconfig: SIOCIFDESTROY: Invalid argument
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2739 (1140884) into master (15cea0a) will not change coverage.
The diff coverage is n/a.

@blackgnezdo
Copy link
Collaborator Author

@tuexen the original line in #1153 seemed to be this way and I suspect it hasn't worked on openbsd since then. It's probably a noop, but a noisy one.

@tuexen tuexen merged commit f62a582 into google:master Sep 2, 2021
@blackgnezdo blackgnezdo deleted the iface-name branch September 2, 2021 15:38
docfate111 pushed a commit to docfate111/syzkaller that referenced this pull request Sep 8, 2021
…gle#2739)

At least on OpenBSD this is the behavior:
% doas ifconfig tun5 create
% doas ifconfig tun5 destroy
% doas ifconfig tun5 create
% doas ifconfig /dev/tun5 destroy
ifconfig: SIOCIFDESTROY: Invalid argument
@blackgnezdo blackgnezdo restored the iface-name branch September 9, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants