Simpler emit call body #3830
Closed
Simpler emit call body #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackgnezdo
force-pushed
the
simpler-emit-call-body
branch
from
338e78e
to
30d9989
Compare
The both compute both touch the same information about the call. Passing precomputed "native" makes it harder to think about emitCallBody in isolation.
Having that happen outside was excessive coupling.
blackgnezdo
force-pushed
the
simpler-emit-call-body
branch
from
30d9989
to
4aeaca9
Compare
|
Doesn't seem like a fruitful approach. I'll try a different tack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md