-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys/linux/vnet: added descriptions for ipv4 icmp extended headers #4045
base: master
Are you sure you want to change the base?
Conversation
Added descriptions for structures and constants for ipv4 icmp echo and reply extended headers.
ident icmp_ext_echo_iio_ident | ||
} [packed] | ||
|
||
icmp_ext_echo_iio_ident { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it rather be a union? I.e. either name, or ipv4, or ipv6?
id int16be | ||
seq_num int16be | ||
icmp_ext_hdr icmp_ext_hdr | ||
iio icmp_ext_echo_iio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datatracker.ietf.org/doc/html/draft-bonica-intarea-eping-04#section-2
When applied to the ICMP Extended Echo Request message, the ICMP Extension Structure contains
one or two instances of the Interface Identification Object
seq_num int16be | ||
icmp_ext_hdr icmp_ext_hdr | ||
iio icmp_ext_echo_iio | ||
data array[int8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the packet include any arbitrary payload beyond what's described above?
The question is related to both request and reply structures.
id int16be | ||
seq_num int16be | ||
icmp_ext_hdr icmp_ext_hdr | ||
iio icmp_ext_echo_iio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the reply contain iio?
https://datatracker.ietf.org/doc/html/draft-bonica-intarea-eping-04#section-3
Please also address this CI error:
It's about your first commit's description. |
The extended headers are for echo and reply echo messages.