Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #4359

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return that functions are not implemented.
  • Loading branch information
kost committed Nov 26, 2023
commit a216e668fbdb4428f687e07752b58f61383fbd8b
8 changes: 3 additions & 5 deletions vm/vmimpl/console_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import (
"io"
"os/exec"
"sync"

_ "github.com/google/syzkaller/pkg/osutil"
)

// Merely to fix build.
Expand All @@ -22,7 +20,7 @@ const (
)

func OpenConsole(con string) (rc io.ReadCloser, err error) {
return nil, fmt.Errorf("failed to get console termios on Windows: %v", err)
return nil, fmt.Errorf("OpenConsole not implemented. Failed to get console termios on Windows")
}

type tty struct {
Expand All @@ -33,12 +31,12 @@ type tty struct {
// OpenRemoteKernelLog accesses to the host where Android VM runs on, not Android VM itself.
// The host stores all kernel outputs of Android VM so in case of crashes nothing will be lost.
func OpenRemoteKernelLog(ip, console string) (rc io.ReadCloser, err error) {
return nil, fmt.Errorf("failed to connect to console server on Windows: %v", err)
return nil, fmt.Errorf("OpenRemoteKernelLog not implemented. Failed to connect to console server on Windows")
}

// Open dmesg remotely.
func OpenRemoteConsole(bin string, args ...string) (rc io.ReadCloser, err error) {
return nil, fmt.Errorf("failed to start adb: %v", err)
return nil, fmt.Errorf("OpenRemoteConsole not implemented. Failed to start adb")
}

// OpenAdbConsole provides fallback console output using 'adb shell dmesg -w'.
Expand Down
Loading