tools/create-openbsd: substitute ubsan_minimal for fuzzer_test #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reliance on -fsanitize-coverage=trace-pc makes clang look for full ubsan libraries. The only one currently available on OpenBSD is ubsan_minimal. We temporarily use it in place of ubsan_standalone. The ubsan_standalone_cxx library seems currently not necessary and so an empty file works in its stead. This is a temporary measure until I figure out the best course of action for making fsanitize-coverage=trace-pc work out of the box on OpenBSD. This should help with one of the issues we just discovered having replaced the base OS image we use to run syzkaller on OpenBSD.
blackgnezdo
force-pushed
the
hack-around-missing-ubsan
branch
from
dd5bd5f
to
751feb0
Compare
a-nogikh
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reliance on -fsanitize-coverage=trace-pc makes clang look for full ubsan libraries. The only one currently available on OpenBSD is ubsan_minimal. We temporarily use it in place of ubsan_standalone. The ubsan_standalone_cxx library seems currently not necessary and so an empty file works in its stead.
This is a temporary measure until I figure out the best course of action for making fsanitize-coverage=trace-pc work out of the box on OpenBSD.
This should help with one of the issues we just discovered having replaced the base OS image we use to run syzkaller on OpenBSD.