pkg/fuzzer/queue: change the queue.Source interface #4944
Conversation
pkg/rpcserver/rpcserver.go
Outdated
| @@ -389,7 +389,7 @@ func (serv *Server) connectionLoop(runner *Runner) error { | |||
| } | |||
| } | |||
| for len(runner.requests)-len(runner.executing) < 2*serv.cfg.Procs { | |||
| req := serv.execSource.Next() | |||
| req, _ := serv.execSource.Next() | |||
There was a problem hiding this comment.
It should shutdown and exit on stop?
There was a problem hiding this comment.
Updated the code to wait for all requests to complete and exit.
| if stop { | ||
| break loop | ||
| } else if req == nil { | ||
| // No new requests so far, but there might be. | ||
| select { | ||
| case <-cfg.Context.Done(): |
There was a problem hiding this comment.
We don't need this context if we have stop.
There was a problem hiding this comment.
I think that shutting RunLocal() down must not necessarily depend on the queue.Source saying it doesn't have any more inputs -- e.g. the fuzzer is not supposed to even run out of them.
There was a problem hiding this comment.
I don't follow.
User of RunLocal provides the source. Why would that source return stop when there is no intention to stop? And what's the difference between returning stop the source and cancelling the context? When what should be used? If they mean the same, why do we need 2 ways to express it?
Return two values -- the request to execute and a boolean flag to indicate whether more requests are coming.
Return two values -- the request to execute and a boolean flag to indicate whether more requests are coming.