Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/rpcserver: tolerate the kernel directory absence #4986

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

a-nogikh
Copy link
Collaborator

@a-nogikh a-nogikh commented Jul 4, 2024

For fuzzing, we don't strictly need the kernel directory or the kernel object file. We just need a disk/kernel image.

For fuzzing, we don't strictly need the kernel directory or the kernel
object file. We just need a disk/kernel image.
@a-nogikh a-nogikh requested a review from dvyukov July 4, 2024 08:10
@dvyukov
Copy link
Collaborator

dvyukov commented Jul 4, 2024

We provide kernel_obj during syzbot builds, right? And it's generally assumed to be provided.
I think it's better if the test will be more realistic and create real config, rather than have a non-realistic test and add more production code to workaround that.

@a-nogikh
Copy link
Collaborator Author

a-nogikh commented Jul 4, 2024

The problem is not in the presubmit test, the problem is that syzkaller has just stopped working without kernel_obj (de facto without the kernel build directory), while it did not require it before.

@dvyukov
Copy link
Collaborator

dvyukov commented Jul 4, 2024

Okay, but I am surprised we observe the difference anywhere. All our configs have all dirs filled.

@a-nogikh a-nogikh added this pull request to the merge queue Jul 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2024
@a-nogikh a-nogikh added this pull request to the merge queue Jul 4, 2024
Merged via the queue into google:master with commit 8773531 Jul 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants