pkg/build/linux: support building with a custom make binary #5368
Conversation
FlorentRevest
force-pushed
the
custom-make
branch
2 times, most recently
from
377a0ea
to
92c50d7
Compare
FlorentRevest
force-pushed
the
custom-make
branch
4 times, most recently
from
b2f262e
to
7167531
Compare
FlorentRevest
requested review from
avagin,
blackgnezdo,
mptre,
markjdb,
tuexen,
mvanotti,
noncombatant,
glpesk and
eepeep
as code owners
a-nogikh
requested review from
a-nogikh
and removed request for
mptre,
tuexen,
noncombatant,
mvanotti,
markjdb,
avagin,
blackgnezdo,
eepeep and
glpesk
pkg/bisect/bisect.go
Outdated
| @@ -241,8 +242,18 @@ func (env *env) bisect() (*Result, error) { | |||
| } | |||
|
|
|||
| cfg := env.cfg | |||
| if err := build.Clean(cfg.Manager.TargetOS, cfg.Manager.TargetVMArch, | |||
| cfg.Manager.Type, cfg.Manager.KernelSrc); err != nil { | |||
| buildCfg := &instance.BuildKernelConfig{ | |||
There was a problem hiding this comment.
I wonder if we can reduce duplication here as it's essentially the same object as the instance.BuildKernelConfig that we create in build(). AFAIK only CompilerBin is different?
There was a problem hiding this comment.
Is the current state close to what you had in mind ? It seems a bit messy to me but maybe with further refactorings or better name we can make it look a bit better
There was a problem hiding this comment.
Hmm, no, not exactly. I had a smaller change in mind, local to bisec.go only :)
E.g. have some base instance.BuildKernelConfig field in env and only patch the Compiler field in build() because the rest are absolutely the same.
There was a problem hiding this comment.
Ah right, I totally misunderstood you sorry ahah. I'll get back to it on monday
FlorentRevest
force-pushed
the
custom-make
branch
from
7167531
to
d320761
Compare
Certain environments might need a specific make command or wrap make calls with extra logic. This lets users provide a path to a custom make binary.
FlorentRevest
force-pushed
the
custom-make
branch
4 times, most recently
from
f3d372e
to
96ed38c
Compare
This unifies the build() and clean() interfaces such that if a custom compiler or make binary is provided in the manager or bisection config, they can be taken into account by the clean() interface.
FlorentRevest
force-pushed
the
custom-make
branch
from
96ed38c
to
5c17fed
Compare
Certain environments might need a specific make command or wrap make calls with extra logic. This lets users provide a path to a custom make binary.