Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/create-openbsd-gce-ci.sh: image for build machine #715

Merged
merged 5 commits into from
Sep 10, 2018
Merged

tools/create-openbsd-gce-ci.sh: image for build machine #715

merged 5 commits into from
Sep 10, 2018

Conversation

blackgnezdo
Copy link
Collaborator

@blackgnezdo blackgnezdo commented Sep 8, 2018

Mostly derived from Go buildlet generator with blessing from bradfitz@.

Fixes #712.

@mptre

Mostly derived from Go buildlet generator with blessing from bradfitz@.
sys/openbsd/buildlet.sh Outdated Show resolved Hide resolved
sys/openbsd/buildlet.sh Outdated Show resolved Hide resolved
sys/openbsd/buildlet.sh Outdated Show resolved Hide resolved
@dvyukov
Copy link
Collaborator

dvyukov commented Sep 8, 2018

Instead of (google/syzkaller#712) in the title, put Fixes #712 into the body (it will autoclose the issue).
And we generally don't do dots in commit titles.

sys/openbsd/buildlet.sh Outdated Show resolved Hide resolved
Change upload instructions and moved the script to the correct
location.

Documented persistent disk setup.
@blackgnezdo blackgnezdo changed the title sys/openbsd: buildlet (google/syzkaller#712). tools/tools/create-openbsd-gce-ci.sh: create disk image Sep 9, 2018
@blackgnezdo blackgnezdo changed the title tools/tools/create-openbsd-gce-ci.sh: create disk image tools/create-openbsd-gce-ci.sh: image for build machine Sep 9, 2018
@blackgnezdo
Copy link
Collaborator Author

I think I addressed all comments and verified that I get the desirable results by running the script and starting the CI on GCE.

@blackgnezdo
Copy link
Collaborator Author

Build failed with an error that I can't imagine is related:
collect2: error: ld terminated with signal 11 [Segmentation fault], core dumped

@krytarowski
Copy link
Collaborator

Looks impressive, CC @R3x

@dvyukov dvyukov merged commit 8c88323 into google:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants