Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/create-openbsd*sh: use cdn.openbsd.org not cloudflare, install vmm-firmware #778

Merged
merged 5 commits into from
Oct 28, 2018
Merged

Conversation

blackgnezdo
Copy link
Collaborator

No description provided.

@blackgnezdo
Copy link
Collaborator Author

@mptre @dvyukov

I suppose we care about these names S_IFMT, S_IFCHR being compliant since the linter is failing builds now:
https://travis-ci.org/google/syzkaller/jobs/444800787

env CGO_ENABLED=1 gometalinter.v2 ./...
sys/openbsd/init.go:24:2:warning: don't use ALL_CAPS in Go names; use CamelCase (golint)
sys/openbsd/init.go:25:2:warning: don't use ALL_CAPS in Go names; use CamelCase (golint)
make[1]: *** [gometalinter] Error 1
make[1]: Leaving directory `/home/travis/gopath/src/github.com/google/syzkaller'
make: *** [presubmit] Error 2
The command "make presubmit" exited with 2.

Is there any reason why the names shouldn't be fixed? The struct in question seems to be private to the package and I don't see any trace of reflection burrowing in the guts of this struct.

@blackgnezdo
Copy link
Collaborator Author

Nevermind, I found a8292de

@blackgnezdo
Copy link
Collaborator Author

@dmitshur, FYI
6832360

@dvyukov dvyukov merged commit 2480809 into google:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants