Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/create-openbsd-gce-ci.sh: simplification due to workers on GCE #827

Merged
merged 1 commit into from
Nov 27, 2018
Merged

tools/create-openbsd-gce-ci.sh: simplification due to workers on GCE #827

merged 1 commit into from
Nov 27, 2018

Conversation

blackgnezdo
Copy link
Collaborator

Remove ramdisk which never found any use while here.

@dvyukov
Copy link
Collaborator

dvyukov commented Nov 26, 2018

What do you think about testing on both GCE and vmd?
For linux we actually want to add qemu instances too because qemu emulates a wide range of hardware, so we can test more drivers. GCE emulates very limited set of hardware.
Are there any advantages of testing on vmd too?
As far as I understand vmd instability is still unresolved, but eventually it should be, it's just some bug.
@mptre

@blackgnezdo
Copy link
Collaborator Author

What do you think about testing on both GCE and vmd?

These conditions need to be met in order for it to become profitable:

  • vmm should become stable, the two known problems have been creating toil for me.
  • vmm should emulate some functionality we want to fuzz.
  • Somebody should write the requisite code for syzkaller.

For linux we actually want to add qemu instances too because qemu emulates a wide range of hardware, so we can test more drivers. GCE emulates very limited set of hardware.
Are there any advantages of testing on vmd too?

As things stand, the main advantages were getting things off the ground and fixing bugs in vmm.

As far as I understand vmd instability is still unresolved, but eventually it should be, it's just some bug.

At least 1 and 2.

But certainly, once we have a reason to do it, I'm all for more coverage. This patch is trivial to revert to get back vmm image support.

@dvyukov dvyukov merged commit 4b6d14f into google:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants