Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openbsd: use console diagnostic code for both vmm and gce #840

Merged
merged 3 commits into from
Dec 2, 2018
Merged

openbsd: use console diagnostic code for both vmm and gce #840

merged 3 commits into from
Dec 2, 2018

Conversation

blackgnezdo
Copy link
Collaborator

cc @mptre

@blackgnezdo
Copy link
Collaborator Author

Works like a charm too.

@dvyukov
Copy link
Collaborator

dvyukov commented Dec 1, 2018

env CGO_ENABLED=1 gometalinter.v2 ./...
vm/gce/gce.go:229:9:warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
make[1]: *** [gometalinter] Error 1
make[1]: Leaving directory `/home/travis/gopath/src/github.com/google/syzkaller'
make: *** [presubmit] Error 2

@dvyukov
Copy link
Collaborator

dvyukov commented Dec 1, 2018

I will fix this up.

@mptre
Copy link
Collaborator

mptre commented Dec 1, 2018 via email

@blackgnezdo
Copy link
Collaborator Author

I will fix this up.

Done.

@dvyukov dvyukov merged commit 7a0edfb into google:master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants