pkg/build/openbsd: require kernel config files as configuration data #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the config was generated directly, but testing multiple configurations makes this cumbersome going forward. This makes kernel_config a mandatory parameter.
|
Go for it. |
|
Bonus: syzkaller UI shows the .config. |
|
Bonus: [syzkaller UI shows the .config](https://syzkaller.appspot.com/bug?id=6447ce7b749cfdc9336ab0b85fbb1b2e48e61af8).
Oh, that's nice! BTW: why the 2 in `pseudo-device kcov 2`?
|
Because I failed to read the man page. I didn't realize it's a boolean flag rather than the number of devices. |
|
On Thu, Dec 06, 2018 at 08:53:20PM +0000, Greg Steuck wrote:
> Bonus: [syzkaller UI shows the .config](https://syzkaller.appspot.com/bug?id=6447ce7b749cfdc9336ab0b85fbb1b2e48e61af8).
> Oh, that's nice! BTW: why the 2 in `pseudo-device kcov 2`?
Because I failed to read the man page. I didn't realize it's a boolean flag rather than the number of devices.
Gotcha, /dev/kcov can be opened more than once per thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the config was generated directly, but testing multiple
configurations makes this cumbersome going forward. This makes
kernel_config a mandatory parameter.
@mptre, this changes the UX, let me know if you feel strongly enough that we need to provide a fallback.