-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new optional field SeverityLevel to Service Alerts feed #136
Add new optional field SeverityLevel to Service Alerts feed #136
Conversation
Looks good! Two small suggestions:
|
I also have a preference for |
Initially I had a preference for I think the main argument for |
This pull request has been open for more than one week, so we are calling for a vote. Voting will be closed on Thursday January 31 at 23:59:59 UTC. |
Just as a side note, in our Urbiplan alerts product we already have this severity level. We use 3 levels: INFO, WARN, CRITICAL. +1 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1 @ibi-group-team There are a few formatting items I commented on that need to be fixed prior to merge. Also, as a side note, the conventions proposed here match Google's severity levels (Critical, Warning, Informational) inferred from Alert Effects as listed on https://support.google.com/transitpartners/answer/6374472?hl=en&ref_topic=6159819. |
+1 |
1 similar comment
+1 |
Voting for this proposal is closed and the results are: So the proposal passes! We'll get this merged. Thank you all! |
Thanks @ibi-group-team and all! |
This is a proposal to add a new field SeverityLevel to the ServiceAlerts feed. The SeverityLevel field would be optional and comprised of enum values:
See discussion here: #133
Announced on the GTFS-realtime Google Groups here: https://groups.google.com/forum/#!topic/gtfs-realtime/t8bpU5gbjDU