Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Recommend providing TripUpdate predictions for the next trip in block #206

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented Feb 28, 2020

Previous discussions (1) (2) have raised the question of whether more than one TripUpdate can be included in a GTFS-realtime feed for a vehicle in the case where the vehicle is serving more than one trip in the same block.

These discussions have concluded that multiple TripUpdates per vehicle are clearly beneficial in this case to avoid prediction "pop-in" for riders as the vehicle transitions from one trip to another and also give riders advance notice of delays that impact downstream trips (e.g., when the known delay exceeds planned layover times between trips).

However, this issue currently isn't addressed anywhere in the spec.

This proposal adds language to the spec recommending that multiple TripUpdates are included in a GTFS-realtime feed for vehicles running more than one trip in the same block. It also normalizes trip-updates.md and reference.md language related to blocks (future work may combine these files).

  1. GitHub PR proposal - "Define rules for propagating delays across trips in same block" - Define rules for propagating delays across trips in same block #110
  2. Google Groups post - "trip is in TripUpdates but not in VehiclePositions feed" - https://groups.google.com/forum/#!topic/gtfs-realtime/lVPOmi9A5vQ

Announced on the GTFS-realtime Google Group at https://groups.google.com/forum/#!topic/gtfs-realtime/69b__hYzKNc.

* Also normalize trip-updates.md and reference.md language related to blocks
@barbeau barbeau added the GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime label Feb 28, 2020
gtfs-realtime/spec/en/reference.md Outdated Show resolved Hide resolved
gtfs-realtime/spec/en/trip-updates.md Outdated Show resolved Hide resolved
@barbeau
Copy link
Collaborator Author

barbeau commented Mar 11, 2020

This pull request has been open for more than one week, so per the Official Process I'm calling for a vote.

Vote will be closed on Thursday March 19th at 23:59:59 UTC.

@paulswartz
Copy link
Contributor

+1

@darylweinberg
Copy link

+1 as long as it is optional
Currently Swiftly only provides predictions for current time +45 minutes. We will need to work closely with consumers if implementing as this will break at least one of my consumers.

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 11, 2020

@darylweinberg Yes, including more than on TripUpdate per vehicle is not strictly required by this change, although it is recommended. It's at the discretion of the producer, with the goal of providing predictions in the feed as far ahead as the producer is confident in to provide better information to the rider.

We will need to work closely with consumers if implementing as this will break at least one of my consumers.

Do you mean that existing consumers aren't currently showing information for future trips in a block (i.e., they are only showing information for the trip the vehicle is currently serving)?

@darylweinberg
Copy link

darylweinberg commented Mar 11, 2020 via email

@jrsanbornjr
Copy link

+1

@harringtonp
Copy link

+!

@skinkie
Copy link
Contributor

skinkie commented Mar 12, 2020

I still dislike the fact that the any order is allowed almost encouraged, while this is trivial to get sorted on the producer side.

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 12, 2020

I still dislike the fact that the any order is allowed almost encouraged, while this is trivial to get sorted on the producer side.

@skinkie That's fair, although that's not what we're voting on in this PR (that text in the diff shows as green because I combined the two block-related rules into one paragraph). The vote in this PR is only for the first bullet point for the recommendation that TripUpdates for subsequent blocks should be included in feeds - in other words, this PR doesn't change the existing statement that producers aren't required to order TripUpdates within the feed by block-order.

I plan to open another issue to discuss the ordering of TripUpdates by block-order.

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 12, 2020

@harringtonp Just to clarify, that +! is +1?

@harringtonp
Copy link

Oops sorry +1 From my perspective (I don't propagate predictions to future trips in a block) the change is a no brainer

@ibi-group-team
Copy link
Contributor

+1

@barbeau
Copy link
Collaborator Author

barbeau commented Mar 20, 2020

Voting is closed on this proposal and the results are:

  • Yes - 5
  • No - 0
  • Abstain - 0

So it passes! Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants